Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement verify method to return SignInDetails #26

Closed
theeugenechong opened this issue Oct 4, 2021 · 1 comment · Fixed by #31 or #32
Closed

Implement verify method to return SignInDetails #26

theeugenechong opened this issue Oct 4, 2021 · 1 comment · Fixed by #31 or #32
Assignees
@theeugenechong
Labels
priority.Medium Nice to have type.Task A task to be done that does not fall under the other categories
Milestone
v1.0

Comments

@theeugenechong
Copy link

UserRole is accepted by execute() method which then executes the command based on the user role
@theeugenechong theeugenechong self-assigned this Oct 4, 2021
@theeugenechong theeugenechong added priority.Medium Nice to have type.Task A task to be done that does not fall under the other categories labels Oct 4, 2021
@theeugenechong theeugenechong added this to the V1.0 milestone Oct 4, 2021
@theeugenechong
Copy link
Author

Improve OOP design/overall design of verify method

theeugenechong added a commit to theeugenechong/tp that referenced this issue Oct 4, 2021
@theeugenechong
Implement verify method to return UserRole which will be passed to co…
5ff67fa 
…mmands being executed in main

Fixes AY2122S1-CS2113T-W13-4#26
@theeugenechong theeugenechong mentioned this issue Oct 4, 2021
Merged
@theeugenechong theeugenechong changed the title Implement verify method to return a UserRole Implement verify method to return SignInDetails Oct 5, 2021
@theeugenechong theeugenechong reopened this Oct 5, 2021
@theeugenechong theeugenechong mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theeugenechong theeugenechong

Labels
priority.Medium Nice to have type.Task A task to be done that does not fall under the other categories
Projects
None yet
Milestone
v1.0
1 participant
@theeugenechong