Adding/moving a directory in VSCode confuse the LSP

[ice1000]

Very easy to reproduce.

[imkiva]

VSCode does not send a file system event when adding/moving a directory?

[imkiva]

It looks like a design problem: microsoft/language-server-protocol#742, microsoft/vscode#60813, microsoft/vscode#90746

We may need our own file system watcher, but it sounds too bad.

[imkiva]

"workspace/didChangeWorkspaceFolders" may does not help

[ice1000]

Does the moved files trigger some notifications?

[ice1000]

microsoft/vscode#60813 (comment)

They said they trigger folder change events

[imkiva]

microsoft/vscode#60813 (comment)

They said they trigger folder change events

It also says "instead of the files within". So we have to manually list files and process the removal and creation.

And it requires a glob pattern "**/*" (watches everything). But this "everything" does not include external changes like git, according to microsoft/language-server-protocol#742 (comment)

So I suppose we will have a file system watcher to watch files without such "optimizations" and also works for external changes.

[imkiva]

Does the moved files trigger some notifications?

Moving a file triggers a file deletion followed by a file creation.

Moving a directory does not trigger file events. But I expect them to be a list of file deletion, a list of file creation, and a move of the directory (a move event makes fixing directory references easier) --- just like what IntelliJ does.

[ice1000]

microsoft/vscode#60813 (comment)
They said they trigger folder change events

It also says "instead of the files within". So we have to manually list files and process the removal and creation.

And it requires a glob pattern "**/*" (watches everything). But this "everything" does not include external changes like git, according to microsoft/language-server-protocol#742 (comment)

So I suppose we will have a file system watcher to watch files without such "optimizations" and also works for external changes.

Yeah.... But I would ask for an option to disable it. It sounds like a disk killer.

[imkiva]

Yeah.... But I would ask for an option to disable it. It sounds like a disk killer.

Yes...