-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aya: remove unwrap
/expect
and NonZero*
in info
#1021
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
ca9dc90
to
f277811
Compare
@marysaka When
And this is with the dependency removed. |
Seems that I misunderstood the origin of that type and got confused sorry about that, can you revert those changes then? 😞 |
Addresses the feedback from aya-rs#1007: - remove panic from `unwrap` and `expect` - Option<NonZero*> => Option<int> with `0` mapping to `None` Refs: aya-rs#1007
f277811
to
94aff3a
Compare
Addresses the feedback from #1007: 🙃
unwrap
andexpect
Option<NonZero*>
=>Option<int>
with0
mapping toNone
- Usesee commentaya_ebpf::binding
inu32
conversion in prog, link, and attach type for more straightforward matching. The::Type
appears to be an alias foru32
, so cast wasn't required.