Add atomic replacement of XDP progs and multihoming of Extension progs #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
dave-tucker
added
feature
dave-tucker
force-pushed
the
bpfd
branch
2 times, most recently
from
0785971
to
71813df
Compare
dave-tucker
force-pushed
the
bpfd
branch
3 times, most recently
from
e124798
to
4932340
Compare
alessandrod
requested changes
Jun 25, 2022
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
This removes the ProgramFd trait with a struct that wraps a RawFd. Program::fd() has been implemented as well as fd() for each Program Type. This allows for a better API than requiring the use of the ProgramFd trait. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
This allows for Extension programs already loaded to the kernel to be attached to another program that is BTF-compatible with the one provided at `load()` time Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
|
@alessandrod comments addressed 👍 |
alessandrod
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
bpf_link_updateXdp::attach_to_link- which allows for atomic replacement of XDP programsExtension::attach_to_program- which allows for an Extension program to be attached to a program other than the one provided atload()- which is required as the verifier needs to know where it will be attached. The program/function should be BTF compatible or the call will fail.These changes are collected together to enable the following use case in
bpfdXdpdispatcher program to an interface with anXdpprogram loaded as anExtensiontofunc1.func2Xdpdispatcher program.func1- it is now attached to the old and new dispatcher simultaneously.func2Xdp::attach_to_linkto perform atomic replacement of the dispatcher programs