aya: Fix Link Pinning #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alessandrod
reviewed
Aug 30, 2022
alessandrod
reviewed
Aug 30, 2022
dave-tucker
force-pushed
the
pin-redux-2
branch
from
63db8d7
to
521dc90
Compare
1. Removes OwnedLink 2. Allows Links to be converted into FdLink 3. Introduces a PinnedLink type to handle wrap FdLink when pinned and support un-pinning Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
dave-tucker
force-pushed
the
pin-redux-2
branch
from
521dc90
to
4c1d645
Compare
alessandrod
added a commit
to alessandrod/aya
that referenced
this pull request
Dec 14, 2022
aya-rs#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
alessandrod
added a commit
to alessandrod/aya
that referenced
this pull request
Dec 26, 2022
aya-rs#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
alessandrod
added a commit
to alessandrod/aya
that referenced
this pull request
Dec 26, 2022
aya-rs#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
alessandrod
added a commit
to alessandrod/aya
that referenced
this pull request
Dec 26, 2022
aya-rs#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
alessandrod
added a commit
to alessandrod/aya
that referenced
this pull request
Dec 26, 2022
aya-rs#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
alessandrod
added a commit
to alessandrod/aya
that referenced
this pull request
Dec 26, 2022
aya-rs#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
alessandrod
added a commit
to alessandrod/aya
that referenced
this pull request
Dec 26, 2022
aya-rs#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
alessandrod
added a commit
that referenced
this pull request
Dec 26, 2022
#366 broke detaching links on drop for everything but FdLink. This restores detach on drop for all links.
dave-tucker
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support un-pinning
Signed-off-by: Dave Tucker dave@dtucker.co.uk