Update VerifierLogLevel to use bitflags
#376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
alessandrod
reviewed
Sep 6, 2022
aya/src/bpf.rs
Outdated
| /// Used to disable all logging. | ||
| const DISABLE = 0; | ||
| /// Logs tracing with details level 1 | ||
| const LEVEL1 = 1; |
There was a problem hiding this comment.
I think this should be DEBUG
alessandrod
requested changes
Sep 6, 2022
aya/src/bpf.rs
Outdated
| /// Logs tracing with details level 1 | ||
| const LEVEL1 = 1; | ||
| /// Log tracing with details level 2 | ||
| const LEVEL2 = 2 | Self::LEVEL1.bits; |
There was a problem hiding this comment.
I think this should be VERBOSE
|
agreed! those are better names |
alessandrod
approved these changes
Sep 6, 2022
alessandrod
reviewed
Sep 6, 2022
aya/src/bpf.rs
Outdated
| const DEBUG = 1; | ||
| /// Enables verbose verifier logging. | ||
| const VERBOSE = 2 | Self::DEBUG.bits; | ||
| /// Enables verifier stats |
There was a problem hiding this comment.
Missing period at the end of the sentence
There was a problem hiding this comment.
@conectado oops just noticed this - could you fix it pls?
There was a problem hiding this comment.
sorry didn't see this message, right away
dave-tucker
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked with @alessandrod here, using
bitflags!to implement theVerifierLogLevel.I think that using the
Defaulttrait might be better than having aDEFAULTvalue in the struct but not so sure on that.Also setting
Level2asLevel1 | 2since in the kernel level 1 seems to imply level 2. Meaning, that when they check for log level they either check forBPF_LOG_LEVEL2(when it's exclusive to 2) orBPF_LOG_LEVELwhen it also include level 1, So I didn't think being able to use 2 was very useful.