Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aya: More pinning fixes #378

Merged
merged 5 commits into from
Sep 8, 2022
Merged

aya: More pinning fixes #378

merged 5 commits into from
Sep 8, 2022

Conversation

dave-tucker
Copy link
Member

@dave-tucker dave-tucker commented Sep 5, 2022 •
edited
Loading

This PR adds some missing lifecycle APIs required for working with pins.

  1. Adds PinnedLink::from_path to create a pinned link from bpffs
  2. Adds From for FdLink to allow for ^ to be converted
  3. Adds TryFrom for XdpLink

Signed-off-by: Dave Tucker dave@dtucker.co.uk

@netlify
Copy link

netlify bot commented Sep 5, 2022 •
edited
Loading

✅ Deploy Preview for aya-rs-docs ready!

Name Link
🔨 Latest commit 7c244e1
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/631a43e7220f430009dd3891
😎 Deploy Preview https://deploy-preview-378--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dave-tucker dave-tucker marked this pull request as draft September 5, 2022 17:35
@dave-tucker dave-tucker marked this pull request as ready for review September 6, 2022 13:10
@dave-tucker
aya: More pinning fixes
4b5b9ab 
This commit fixes a bug and adds some missing lifecycle APIs.

1. Adds PinnedLink::from_path to create a pinned link from bpffs
2. Adds From<PinnedLink> for FdLink to allow for ^ to be converted
3. Adds From<FdLink> for XdpLink

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker dave-tucker marked this pull request as draft September 6, 2022 15:52
@dave-tucker
Copy link
Member Author

Marking draft (again).
bpf_link_get_info_by_fd fails (my fault) and also needs an integration test for the link lifecyle things.

@dave-tucker
aya: Rename bpf_obj_get_info_by_id
6af2053 
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker
aya: Replace From<FdLink> for XdpLink with TryFrom
f961cbb 
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker
aya-tool: Fix clippy lints
4ed587b 
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker
Copy link
Member Author

Fixed. This is now ready for review.

@dave-tucker dave-tucker marked this pull request as ready for review September 7, 2022 16:25
alessandrod
alessandrod approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@alessandrod alessandrod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dave-tucker
tests: Add integration test for pinning lifecycle
7c244e1 
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker dave-tucker merged commit 98e25ca into aya-rs:main Sep 8, 2022
@dave-tucker dave-tucker added aya This is about aya (userspace) fix A PR that is a small change or fixes a bug labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrod alessandrod alessandrod approved these changes

Assignees
No one assigned
Labels
aya This is about aya (userspace) fix A PR that is a small change or fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dave-tucker @alessandrod