aya: add BpfLoader::set_max_entries #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
aztecher
force-pushed
the
impl-set_max_entries
branch
from
1ba77b0
to
1669223
Compare
|
Lint errors are unrelated to your changes, let me fix them. |
vadorovsky
requested changes
Sep 19, 2022
There was a problem hiding this comment.
Thank you for your contribution! :)
Just one doc nit (we always finish sentences with periods).
Also, you will need to rebase once #394 gets merged.
Add BpfLoader::set_max_entries, which sets the max_entries for the specified map, as the load-time option. The max_entries set at map initialization in the ebpf component can be overwritten by this method called on the userspace component. If you want to set max_entries for multiple maps in an ebpf component, you can do so by calling set_max_entries in the form of a method chain. Fixes: aya-rs#308 Refs: aya-rs#292
aztecher
force-pushed
the
impl-set_max_entries
branch
from
1669223
to
2eccf1d
Compare
alessandrod
approved these changes
Sep 20, 2022
Looks good! Thanks @aztecher and thank you for reviewing Michal! |
dave-tucker
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #308.
Add BpfLoader::set_max_entries so that the max_entries of any map on the ebpf component
can be set at the load-time on the userspace component.
The max_entries of the map that matches the map name given in the first argument is overwritten
by the value of the second argument.
Fixes: #308
Refs: #292