XDP Multi-Buffer Support #519
Conversation
This adds support for loading XDP programs that are multi-buffer capable, which is signalled using the xdp.frags section name. When this is set, we should set the BPF_F_XDP_HAS_FRAGS flag when loading the program into the kernel. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Awesome, that was fast! Looks good from my point of view 👍 One minor comment: I wonder if |
| @@ -14,7 +14,7 @@ static FOO: Array<u32> = Array::<u32>::with_max_entries(10, 0); | |||
| #[map(name = "BAR")] | |||
| static BAZ: Array<u32> = Array::<u32>::with_max_entries(10, 0); | |||
|
|
|||
| #[xdp] | |||
| #[xdp(multibuffer = "true")] | |||
There was a problem hiding this comment.
I think we shouldn't switch all tests to use frags. It's unlikely but just in case we end up breaking the non-frags case.
There was a problem hiding this comment.
ack. we still have 2 aya xdp programs in the integration tests that will ensure we support the non-frags case too... and any of the C progs used in integration tests are just plain old xdp
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
|
@alessandrod fixed all comments except for the note re: tests since we've still got good coverage on integration tests for the frags and non-frags cases. |
|
Thanks guys, you rock! 👏 |
dave-tucker
added
feature
Fixes: #516