aya: Remove iter_key from LPM Trie API #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vadorovsky
reviewed
Feb 21, 2023
vadorovsky
approved these changes
Feb 22, 2023
|
@alessandrod are you ok with the API https://github.com/aya-rs/aya/pull/526/files#diff-f6d6661573434c62eecc651f4986dfa4e5235ad59ee99bcb4478a370a7fb8621R124 here that adds The use cases are:
|
dave-tucker
added
fix
dave-tucker
changed the title
alessandrod
reviewed
Mar 25, 2023
alessandrod
reviewed
Mar 25, 2023
alessandrod
reviewed
Mar 25, 2023
|
@dave-tucker Ping, would be nice to have Alessandro's comments addressed :) |
Based on the discussion in Discord we've decided to drop the iter_key() API for LPM Trie. According to the kernel self-tests and experimentation done in Aya, providing a key into bpf_map_get_next_id will either: - If key is an EXACT match, proceed iterating through all keys in the trie from this point - If key is NOT an EXACT match, proceed iterating through all keys in the trie starting at the leftmost entry. An API in Aya could be crafted that gets the LPM match + less specific matches for a prefix using these semantics BUT it would only apply to userspace. Therefore we've opted out of fixing this. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
dave-tucker
changed the title
alessandrod
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in Discord1 we've decided to drop the
iter_keys() API for LPM Trie. According to the kernel self-tests and
experimentation done in Aya, providing a key into bpf_map_get_next_id
will either:
trie from this point
the trie starting at the leftmost entry.
An API in Aya could be crafted that gets the LPM match + less specific
matches for a prefix using these semantics BUT it would only apply to
userspace. Therefore we've opted out of fixing this.