Add tests for relocations + fixes #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alessandrod
force-pushed
the
reloc-fixes
branch
from
344e357
to
d77a2c5
Compare
In preparation of adding actual ELF relocation tests
Avoid allocations and add comments explaining how things work.
Clearly split the code between `.maps`, `maps` and data maps (bss, data,
rodata). Sprinkle comments.
Remove MapKind which was effectively only needed since we used to have
one variant - BpfSectionKind::Data - to represent all data maps. Instead
add explicit BpfSectionKind::{Data, Rodata, Bss} variants and match on
those when we initialize maps.
alessandrod
force-pushed
the
reloc-fixes
branch
from
d77a2c5
to
fc791fd
Compare
vadorovsky
requested changes
Apr 12, 2023
alessandrod
force-pushed
the
reloc-fixes
branch
from
fc791fd
to
a5411c8
Compare
Fix R_BPF_64_64 text relocations in sections other than .text (for instance .text.unlikely). Also fix misc bugs triggered by integration tests.
alessandrod
force-pushed
the
reloc-fixes
branch
from
a5411c8
to
3a8380d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
MapKindand adds comments explaining the difference between the oldmaps/blahsection, the new legacy (tm)mapssection, and the BTF.mapssection. (I hope ebpf never changes anything to do with maps again, or otherwise I guess we'll have to start using.maps?!next) fab31eaobjectcrate hides away the actual BPF relocation types. I've decided that I want to remove theobjectcrate and use a smol ad-hoc 300 lines of code ELF parser I wrote for rbpf. I started doing that and the diff got out of hand, so I'll do that separately at some point.