aya: Apply BTF relocations to all functions #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
marysaka
force-pushed
the
fix/btf-reloc-all-functions
branch
2 times, most recently
from
78ce3b6
to
d62fda7
Compare
vadorovsky
approved these changes
May 13, 2023
alessandrod
reviewed
May 27, 2023
marysaka
force-pushed
the
fix/btf-reloc-all-functions
branch
2 times, most recently
from
28be1cc
to
c737e5c
Compare
alessandrod
approved these changes
May 29, 2023
This fix aya wrong logic causing non entrypoint functions to not have any BTF relocations working. Also fix missing section_offset computation for instruction offset in multiple spots.
marysaka
force-pushed
the
fix/btf-reloc-all-functions
branch
from
c737e5c
to
c4e721f
Compare
Should be ready to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix aya wrong logic causing non entrypoint functions to not have any BTF relocations working.
As a result, I needed to refactor how functions are stored and handled.
I also fixed missing section_offset computation for instruction offset in multiple spots.