Misc testing improvements #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tamird
commented
Jul 28, 2023
tamird
commented
- integration-test: rerun-if-changed=integration-ebpf
- Do not escape newlines on Err(LoadError).unwrap()
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tamird
force-pushed
the
cache-again-god-damn-it
branch
from
6827b9b
to
9d653a7
Compare
tamird
force-pushed
the
cache-again-god-damn-it
branch
2 times, most recently
from
d854a13
to
115d64f
Compare
See code commentary for details.
Wrap verifier logs in a newtype whose `Debug` impl emits unescaped newlines. This improves ergonomics in tests where we `Result::unwrap()` those load errors; when these fail today they emit the errors with newlines escaped, making them incredibly difficult to read.
tamird
force-pushed
the
cache-again-god-damn-it
branch
from
115d64f
to
8961be9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.