Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aya: Don't store btf_fd in MapData #702

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

dave-tucker
Copy link
Member

This is only used in create and therefore can be passed
as a parameter.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for aya-rs-docs ready!

Name Link
🔨 Latest commit db975e9
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/64d636c5ac4a850008b66c1f
😎 Deploy Preview https://deploy-preview-702--aya-rs-docs.netlify.app/src/aya/sys/bpf.rs
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be preferable to squash these two commits, imo.

aya/src/maps/bloom_filter.rs Outdated Show resolved Hide resolved
aya/src/maps/lpm_trie.rs Outdated Show resolved Hide resolved
@tamird tamird added the api/needs-review Makes an API change that needs review label Jul 31, 2023
@mergify
Copy link

mergify bot commented Jul 31, 2023

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

@mergify mergify bot requested a review from alessandrod July 31, 2023 11:09
@mergify mergify bot added aya This is about aya (userspace) test A PR that improves test cases or CI labels Jul 31, 2023
@dave-tucker
Copy link
Member Author

Related to the api changes: #703

@mergify
Copy link

mergify bot commented Aug 2, 2023

@dave-tucker, this pull request is now in conflict and requires a rebase.

This is only used in create and therefore can be passed
as a parameter.

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker dave-tucker merged commit 03c5012 into aya-rs:main Aug 11, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/needs-review Makes an API change that needs review aya This is about aya (userspace) test A PR that improves test cases or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants