fix load time #769
Merged
fix load time #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Broken: Fixed: Bpftool output as verification: |
astoycos
force-pushed
the
fix-loaded-at
branch
from
afe8393
to
cc97658
Compare
tamird
approved these changes
Sep 22, 2023
|
|
||
| let loaded_at = prog.info().unwrap().loaded_at(); | ||
|
|
||
| // make sure loaded_at() api is correct with a millisecond tolerance. |
There was a problem hiding this comment.
Wouldn't it be more robust to:
- get current time t1
- load
- get current time t2
- assert load is been t1 and t2
?
astoycos
force-pushed
the
fix-loaded-at
branch
from
cc97658
to
5f3d33f
Compare
tamird
reviewed
Sep 22, 2023
|
|
||
| let loaded_at = prog.info().unwrap().loaded_at(); | ||
|
|
||
| assert!(t1 < loaded_at && t2 > loaded_at); |
There was a problem hiding this comment.
this assertion doesn't emit information on failure, which seems bad. how about
let range = t1..t2;
assert!(range.contains(loaded_at), "{range}.contains({loaded_at})");or something like that.
Time since boot is defined as the UNIX_EPOCH plus the duration since boot. which is realtime - boottime NOT boottime - realtime. Add a integration test to ensure this doesn't happen again. Signed-off-by: astoycos <astoycos@redhat.com>
astoycos
force-pushed
the
fix-loaded-at
branch
from
5f3d33f
to
dffff1c
Compare
tamird
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time since boot is defined as the UNIX_EPOCH plus the duration since boot. which is realtime - boottime NOT boottime - realtime.