aya/maps: rework TryFrom macros #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajwerner
force-pushed
the
ajwerner/TryFrom-macros
branch
from
ec29fe3
to
6283d98
Compare
tamird
reviewed
Sep 1, 2023
ajwerner
force-pushed
the
ajwerner/TryFrom-macros
branch
2 times, most recently
from
081976f
to
ae942e0
Compare
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
mergify
bot
added
api/needs-review
tamird
approved these changes
Sep 1, 2023
alessandrod
approved these changes
Sep 1, 2023
ajwerner
force-pushed
the
ajwerner/TryFrom-macros
branch
from
ae942e0
to
f9b4fc1
Compare
The old macros were repetitive and inflexible. This unifies the various macros used to generate TryFrom implementations for map implementations from the relevant map enum variants. Cleanup in anticipation of fixing aya-rs#636. The API changes are just about renaming the return to Self and Self::Error; they are not real changes.
ajwerner
force-pushed
the
ajwerner/TryFrom-macros
branch
from
f9b4fc1
to
2a1bf60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old macros were repetitive and inflexible. This unifies the various
macros used to generate TryFrom implementations for map implementations
from the relevant map enum variants.
Cleanup in anticipation of fixing #636.
The API changes are just about renaming the return to Self and
Self::Error; they are not real changes.