aya: add program_info() api to Program
#782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
mergify
bot
added
api/needs-review
alessandrod
reviewed
Sep 16, 2023
aya/src/programs/mod.rs
Outdated
| /// | ||
| /// This information is populated at load time by the kernel and can be used | ||
| /// to get kernel details for a given [`Program`]. | ||
| pub fn program_info(&self) -> Result<ProgramInfo, ProgramError> { |
There was a problem hiding this comment.
Why program_info and not info?
There was a problem hiding this comment.
Done! Also fixed up the existing API so that we're consistent.
tamird
reviewed
Sep 16, 2023
Add a new api to the outer level `Program` structure which allows users to get the program's kernel info before casting it to an explicit program variant. Signed-off-by: astoycos <astoycos@redhat.com>
alessandrod
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new api to the outer level
Programstructure which allows users to get the program's kernel info before casting it to an explicit program variant.