Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aya: import types from std::ffi rather than libc #811

Merged
merged 1 commit into from
Oct 11, 2023
Merged

aya: import types from std::ffi rather than libc #811

merged 1 commit into from
Oct 11, 2023

Conversation

tamird
Copy link
Member

@tamird tamird commented Oct 11, 2023

No description provided.

@tamird tamird requested a review from ajwerner October 11, 2023 14:57
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5cdd1ba
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/6526b980988bc10007a15034
😎 Deploy Preview https://deploy-preview-811--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added the aya This is about aya (userspace) label Oct 11, 2023
@tamird tamird mentioned this pull request Oct 11, 2023
Merged
@mergify
Copy link

mergify bot commented Oct 11, 2023

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

@mergify mergify bot added api/needs-review Makes an API change that needs review test A PR that improves test cases or CI labels Oct 11, 2023
@tamird
Copy link
Member Author

tamird commented Oct 11, 2023

@alessandrod FYI this now changes API but the types are identical.

@tamird tamird merged commit b7ceee4 into aya-rs:main Oct 11, 2023
21 checks passed
@tamird tamird deleted the libc branch October 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrod alessandrod alessandrod approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees
No one assigned
Labels
api/needs-review Makes an API change that needs review aya This is about aya (userspace) test A PR that improves test cases or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamird @alessandrod