Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appease new nightly lints #861

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Appease new nightly lints #861

merged 2 commits into from
Jan 7, 2024

Conversation

tamird
Copy link
Member

@tamird tamird commented Jan 6, 2024

See individual commits.

```
error: lint `unused_tuple_struct_fields` has been renamed to `dead_code`
  --> aya/src/lib.rs:74:5
   |
74 |     unused_tuple_struct_fields,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `dead_code`
   |
   = note: `-D renamed-and-removed-lints` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(renamed_and_removed_lints)]`
```

See rust-lang/rust@9fcf9c141068984ffcbb4cb00c.
```
error: field `0` is never read
   --> bpf/aya-bpf/src/helpers.rs:737:22
    |
737 | pub struct PrintkArg(u64);
    |            --------- ^^^
    |            |
    |            field in this struct
    |
    = note: `PrintkArg` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
    |
737 | pub struct PrintkArg(());
    |                      ~~
```

See rust-lang/rust#119659.
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9861c14
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/659959cf8b43510008a9dc58
😎 Deploy Preview https://deploy-preview-861--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added aya This is about aya (userspace) aya-bpf This is about aya-bpf (kernel) labels Jan 6, 2024
@tamird tamird merged commit 604742a into aya-rs:main Jan 7, 2024
21 checks passed
@tamird tamird deleted the appease-lint branch January 7, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aya This is about aya (userspace) aya-bpf This is about aya-bpf (kernel)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants