Expose io_error in SyscallError #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a bpf syscall fails, it would be useful to know if this is due to not having enough permissions or that the kernel does not have BPF support. Ubuntu kernels are compiled without `CONFIG_BPF_LIRC_MODE2` so this is important for https://github.com/seanyoung/cir/ : I would like to present a useful error saying your kernel does not support BPF IR decoders, go fix your kernel. Also, when removing all BPF programs using `cir config --clear` then if there is no support for BPF, there is nothing to clear and the syscall error can be ignored.
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
alessandrod
approved these changes
Apr 20, 2024
|
It would be great to have this merged, please let me know if there is anything I can do to make this more amenable |
|
Oops sorry forgot to merge when I approved two weeks ago! |
|
Wonderful thank you @alessandrod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bpf syscall fails, it would be useful to know if this is due to not having enough permissions or that the kernel does not have BPF support.
Ubuntu kernels are compiled without
CONFIG_BPF_LIRC_MODE2so this is important for https://github.com/seanyoung/cir/ : I would like to present a useful error saying your kernel does not support BPF IR decoders, go fix your kernel.Also, when removing all BPF programs using
cir config --clearthen if there is no support for BPF, there is nothing to clear and the syscall error can be ignored.