Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xmlns attribute for downloaded SVG #283

Merged

Conversation

zehraworks
Copy link
Contributor

Fix #262

@aykutkardas
Copy link
Owner

Adding a new method increases code duplication.

You can add a new parameter for the existing method instead.

If this parameter exists, attributes that should be in SVG files are added.

export const convertToSVG = ({ icon }: IconSetItem, size = 32, isFile = false) => {...}

// ...


convertToSVG(icon, size, true)

@aykutkardas aykutkardas merged commit 76c9323 into aykutkardas:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing xmlns attribute when downloading a new SVG file
2 participants