Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-flygraph-digraph-impl has error, nil protocol method impl #90

Closed
cemerick opened this issue Oct 21, 2016 · 1 comment
Closed

Comments

@cemerick
Copy link
Contributor

While working out making loom Clojure[Script]-portable, I came across this:

:in-edges (get-in default-digraph-impl [:all :in-edges])

default-digraph-impl has no value at [:all :in-edges]. I presume this should be (get default-digraph-impl :in-edges).

I'm not going to make this change, though: the tests are passing as-is, so flygraph digraphs are apparently not covered, and I have no use for flygraphs currently, so I'm not in a position to write those tests.

@aysylu aysylu closed this as completed in 0cc75f9 Feb 15, 2017
@aysylu
Copy link
Owner

aysylu commented Feb 15, 2017

Good catch. Thanks for reporting the issue, @cemerick!

aysylu added a commit that referenced this issue Feb 15, 2017
aysylu added a commit that referenced this issue Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants