Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces guava with java native alternatives. The intent is to make this library a bit more portable for runtime environments that force old incompatible versions of guava (such as spark and hadoop).
Some PR notes: there isn't a clear alternative to VisibleForTesting, but since the annotation isn't parsed anywhere I figured a comment was functionally equivalent. There isn't a great Iterables.partition built-in in java8 that preserves ordering, so I used a basic iterating subList approach that should be readable at a glance.
FWIW so far I've worked around the guava compatibility issue by relocating the guava packages, and it seems to work fine, but relocation is a bit clunky and removing guava was straight forward.