Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API_WITH_TRANSACTIONS and API_WITH_TILES environment variables don't work #969

Open
aripollak opened this issue Sep 24, 2021 · 1 comment

Comments

@aripollak
Copy link

Describe the bug
In my docker-compose.yml, I have the following:

  franklin:
    image: quay.io/azavea/franklin:latest
    depends_on:
      database:
        condition: service_healthy
    command:
      - serve
    volumes:
      - ./:/opt/franklin/
    environment:
      - ENVIRONMENT=development
      - DB_HOST=database.service.internal
      - DB_NAME=franklin
      - DB_USER=franklin
      - DB_PASSWORD=franklin
      - API_WITH_TRANSACTIONS=true
      - API_WITH_TILES=true
    links:
      - database:database.service.internal
    ports:
      - "9090:9090"

When I start the container with docker-compose up -d, the tile and transaction endpoints aren't listed in the links/conformsTo, but the API_WITH_TRANSACTIONS and API_WITH_TILES environment variables are documented as being things that should work. If I instead add --with-transactions --with-tiles to the command, I do see those extra endpoints as expected.

Expected behavior
I'd expect API_WITH_TRANSACTIONS=true and API_WITH_TILES=true environment variables to enable those extra endpoints.

Additional context

@jisantuc
Copy link
Contributor

Best guess -- orFalse makes it so that the orElse always chooses the first (since it's an option that resolved to a setting successfully) https://github.com/azavea/franklin/blob/master/application/src/main/scala/com/azavea/franklin/commands/ApiOptions.scala#L70-L98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants