[Fix/core] fix pit of saron

[betayi]

Changes Proposed:

• fix Boss in Pit of Saron Can not kill #10123

Issues Addressed:

• Closes Boss in Pit of Saron Can not kill #10123

SOURCE:

Tests Performed:

• tested

How to Test the Changes:

1.kill boss 1 and 2
2. go throught cave
3.stand in front of boss 3, to watch if trigger the combat start event

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[opcode02]

i tried this patch, and ran through the pit of sauron in both normal and heroic, seems to have the same behavior as before, no trigger at the top of the hill after killing krick and ick and killing those groups of 5 undead things going up the hill.

[betayi]

look this, i have finish the whole instance without any mistake

[Krath]

look this, i have finish the whole instance without any mistake

I don't think this is a proper fix. The encounter always worked as intended and the instance code hasn't been touched in months. Something else broke the trigger before the cave.

[betayi]

look this, i have finish the whole instance without any mistake

I don't think this is a proper fix. The encounter always worked as intended and the instance code hasn't been touched in months. Something else broke the trigger before the cave.

it's only fix this instance trigger at current branch commits, and won't effect others, why not properly? does the commit cause new problem a proper fix? we can correct it properly sometimes in future , at least，it works fine, without cause new problem.

[opcode02]

Ok, I tested the newer patch and it definitely triggers correctly now, now you can finish the pit of saron's zones bosses to the end and everything triggers correctly.

[adink1]

Triggers correctly, but the last NPC that appears won't take part in the battle

[fullofstarschen]

This Patch works fine.

Triggers correctly, but the last NPC that appears won't take part in the battle

[ghost]

This PR doesn't make any sense. Why are you commenting these lines? If they do nothing here, just re-write this.

[adink1]

The latest version still can't trigger, only this patch can be used

[Rosencrant]

This patch Don't Work.

[nestormourino]

Working fine,

[ghost]

I confirmed that the fix work. If you test the PR, care with events that broke when you go fast (like .die command).

[ghost]

PR Close. A proper fix do the same thing (#10819 ).