fix(Core/SAI): Allow scripts to target the summoner of a TempSummon

[SilentCLD]

Changes Proposed:

Allow scripts to target the summoner of a TempSummon, this was removed in PR #9372 (TempSummons do not use the same path as GetCharmerOrOwnerGUID())

Issues Addressed:

• Closes Pit of Saron not begins #10760
• Closes Boss in Pit of Saron Can not kill #10123

Tests Performed:

• Completed dungeon Pit of Saron

How to Test the Changes:

1. .tele PitOfSaron
2. Kill the first two bosses and wait for the RP section to finish
3. Start running up the hill to Tryrannus
4. 10 creatures will spawn, once killed the next set will correctly spawn as you reach the top and the dungeon can be completed

[Nefertumm]

For tester: Make sure this doesn't break the changes introduced by the PR linked too!

[Kisskam]

I have done the tests and the application was successful. Now you can make this dungeon normal.

• I don't speak English so I use a translation tool.

[pangolp]

I have done the tests and the application was successful. Now you can make this dungeon normal.

• I don't speak English so I use a translation tool.

Welcome to the world of testing

[ghost]

Tested and work, but I'm unable to see a respawn of Blazings like it's mention on #9372 . I got also 3 crash after doing: .tele pitofsaron, instance reset.

@Kitzunu or @Nyeriah
This PR and the PR #10150 fix the same bugs. The PR #10150 fix also the issue #10760 but it's not mentioned.

4624729f3ba1_worldserver.exe.zip

[SilentCLD]

Tested and work, but I'm unable to see a respawn of Blazings like it's mention on #9372 . I got also 3 crash after doing: .tele pitofsaron, instance reset (no crash without this PR).

@Kitzunu or @Nyeriah This PR and the PR #10150 fix the same bugs. The PR #10150 fix also the issue #10760 but it's not mentioned.

4624729f3ba1_worldserver.exe.zip

I quickly tested this on the commit before in this branch (0ce1c96) and the Blazings don't respawn so it's safe to say it's not related to this PR.

The crash is also unrelated and appears to be coming from the mutex in InstanceSave::RemovePlayer. I can reliably reproduce this by:

1. binding to an instance
2. gracefully restarting the server
3. instance unbind all
   

   azerothcore-wotlk/src/server/game/Instances/InstanceSaveMgr.cpp

   Lines 217 to 224 in e2d7dc9

   	bool InstanceSave::RemovePlayer(ObjectGuid guid, InstanceSaveMgr* ism)
   	{
   	std::lock_guard<std::mutex> guard(_lock);
   	m_playerList.remove(guid);
   	// ism passed as an argument to avoid calling via singleton (might result in a deadlock)
   	return ism->DeleteInstanceSaveIfNeeded(this->GetInstanceId(), false);
   	}

PR #10150 is not the proper fix, it only bypasses this issue by removing the requirement to kill the spawned creatures before continuing. This PR effects anything that has a smart script target of OWNER_OR_SUMMONER

[Alexander990608]

It doesn't work now, when you kill first spot, when you go up, it doesn't summon other mobs near the cave, you need to restart the server, after you kill those mobs and you go in cave, nothing happens.. So practically you must restart server for like 2 times for last Boss work. :)

[ghost]

It doesn't work now, when you kill first spot, when you go up, it doesn't summon other mobs near the cave, you need to restart the server, after you kill those mobs and you go in cave, nothing happens.. So practically you must restart server for like 2 times for last Boss work. :)

Strange... I will redonne some tests this night.

[Alexander990608]

It doesn't work now, when you kill first spot, when you go up, it doesn't summon other mobs near the cave, you need to restart the server, after you kill those mobs and you go in cave, nothing happens.. So practically you must restart server for like 2 times for last Boss work. :)

Strange... I will redonne some tests this night.

Thank you!! I don't know what is happening but when you kill those 2 bosses and after you go up, first mobs are comming, but next one near cave event are not comming..

[SilentCLD]

It doesn't work now, when you kill first spot, when you go up, it doesn't summon other mobs near the cave, you need to restart the server, after you kill those mobs and you go in cave, nothing happens.. So practically you must restart server for like 2 times for last Boss work. :)

@Alexander990608
Trigger 1 can activate once both bosses are killed and Tyrannus has done his RP sequence, entering this trigger will spawn 2 casters which will then spawn 4 other creatures each.
Trigger 2 can activate once all 10 creatures have been killed, entering this trigger will spawn the next wave before the cave

When running through with GM commands it's best to use the .damage command (you can put something like .damage 100000 in a macro) instead of .die as that may have unintended side-effects
To further help you can use the .debug areatriggers command which will alert you when you enter an area trigger
Trigger 1 = 5578
Trigger 2 = 5579

There is also Trigger 5580 in the cave which starts the event which spawns the icicles

[Alexander990608]

.debug areatriggers

I did what you said, still bugged for me! I don't really know what is happening.. After i restart server and going to Trigger 2, it works, when i kill those mobs and i go in cave event for Trigger 3 icicles it doesn't work, i must restart the server again.

Screenshot here:

[ghost]

.debug areatriggers

I did what you said, still bugged for me! I don't really know what is happening.. After i restart server and going to Trigger 2, it works, when i kill those mobs and i go in cave event for Trigger 3 icicles it doesn't work, i must restart the server again.

Screenshot here:

Do you wait that all the events start and finish ? Are you in gm mode ? Are you sure that you are on the right PR ? I have recorded my test and say us what you do differently, because I'm unable to reproduce this.

https://youtu.be/n1TdHaL0mu8

[SilentCLD]

I've spoken with Alexander directly and confirmed that the PR was not active on his test server. This can be re-added to the merge queue.