Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/Debug): GetDebugInfo implementation #12705

Merged
merged 1 commit into from Aug 15, 2022
Merged

feat(Core/Debug): GetDebugInfo implementation #12705

merged 1 commit into from Aug 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2022

Co-authored-by: jackpoz giacomopoz@gmail.com

Changes Proposed:

  • Implement GetDebugInfo function
  • Improve debug informations in ASSERTs
  • It's the TC base but functions can be modified to add or remove informations usefull/useless for us.

Issues Addressed:

SOURCE:

TrinityCore/TrinityCore@9a924fb

Tests Performed:

  • None

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Cherry-pick: TrinityCore/TrinityCore@9a924fb

Co-authored-by: jackpoz <giacomopoz@gmail.com>
@Yehonal Yehonal added CORE Related to the core file-cpp Used to trigger the matrix build labels Aug 12, 2022
@ghost ghost added the Ready to be Reviewed label Aug 12, 2022
@ghost ghost removed the Ready to be Reviewed label Aug 13, 2022
@Nyeriah Nyeriah merged commit d0d1671 into azerothcore:master Aug 15, 2022
ghost pushed a commit to sogladev/azerothcore-wotlk that referenced this pull request Aug 16, 2022
Cherry-pick: TrinityCore/TrinityCore@9a924fb

Co-authored-by: jackpoz <giacomopoz@gmail.com>

Co-authored-by: jackpoz <giacomopoz@gmail.com>
UltraNix pushed a commit to UltraNix/azerothcore-wotlk that referenced this pull request Aug 21, 2022
Cherry-pick: TrinityCore/TrinityCore@9a924fb

Co-authored-by: jackpoz <giacomopoz@gmail.com>

Co-authored-by: jackpoz <giacomopoz@gmail.com>
@ghost ghost deleted the GetDebugInfo branch September 14, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants