refactor(SmartAI): align some SMART_ACTION(s) to TC

[FrancescoBorzi]

CHANGES PROPOSED:

Aligned some SmartAI actions. This will make easier to import SmarAI from TC 3.3.5.

• Move SMART_ACTION_SET_SIGHT_DIST to 121 (previous value 136)
• Move SMART_ACTION_FLEE to 122 (previous value 137)
• Move SMART_ACTION_ADD_THREAT to 123 (previous value 138)
• Move SMART_ACTION_LOAD_EQUIPMENT to 124 (previous value 139)
• Move SMART_ACTION_TRIGGER_RANDOM_TIMED_EVENT to 125 (previous value 140)
• Move SMART_ACTION_REMOVE_ALL_GAMEOBJECTS to 126 (previous value 146)

ISSUES ADDRESSED:

Updates #1326

TESTS PERFORMED:

Builds, runs.

HOW TO TEST THE CHANGES:

• Test some existing SmartAI scripts (ideally checking all those moved actions)

Target branch(es):

Master

[wetbrownsauce]

Specific scripts used for testing:

• smart_script 18598 uses action type 122 (prev 137) to make Orc Prisoners in The Escape From Durnholde flee after all incendiary bombs are planted.

• smart_script 7915 uses action type 123 (prev 138) to set the aggro of the Walking Bombs spawned by the last boss in Gnomeregan.

• smart_script 23049 uses action type 124 (prev 139) to update the Shadowmoon Weaponmaster's weapons in combat (when changing stances).

• smart_script 3640 uses action type 125 (prev 140) for Evolving Ectoplasm to randomly have them cast a spell which changes their color.

• smart_script 14464 uses action type 126 (prev 146) to despawn all elemental rift gameobjects in Azshara after Avalanchion is slain.

• smart_script -83067 uses action type 121 (prev 136) to set the sight distance of Bloodwarder Protectors in The Botanica. This was the harder one to test because I don't fully understand it. I just measured with .dist.

Results after applying PR:

• Orc Prisoners flee when all incendiary bombs are set in The Escape From Durnholde just as they did before the PR.

• Walking Bombs in Gnomeregan spawn and aggro to players just as they did before the PR.

• Shadowmoon Weaponmasters update their weapons in combat as they did before the PR.

• Evolving Ectoplasms randomly change their colors as they did before the PR.

• Killing Avalanchion in Azshara despawns all rift game objects as it did before the PR.

• Bloodwarder Protectors in The Botanica aggro from roughly the same .dist as before the PR (~20).

👍

[FrancescoBorzi]

@wetbrownsauce awesome! thanks a lot!!