New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CI): prevent PRs that cause DB errors to get on master #1407
Changes from 2 commits
27bf759
ac01ea1
bf26ad0
9eead95
41f19dd
c0dba29
faf27c4
f063a77
d60feff
6e5cb8e
1df5973
cbd34b3
79e8109
3b45af5
File filter...
Jump to…
@@ -1350,18 +1350,21 @@ void World::SetInitialWorldSettings() | ||
///- Init highest guids before any table loading to prevent using not initialized guids in some code. | ||
sObjectMgr->SetHighestGuids(); | ||
|
||
///- Check the existence of the map files for all races' startup areas. | ||
if (!MapManager::ExistMapAndVMap(0, -6240.32f, 331.033f) | ||
|| !MapManager::ExistMapAndVMap(0, -8949.95f, -132.493f) | ||
|| !MapManager::ExistMapAndVMap(1, -618.518f, -4251.67f) | ||
|| !MapManager::ExistMapAndVMap(0, 1676.35f, 1677.45f) | ||
|| !MapManager::ExistMapAndVMap(1, 10311.3f, 832.463f) | ||
|| !MapManager::ExistMapAndVMap(1, -2917.58f, -257.98f) | ||
|| (m_int_configs[CONFIG_EXPANSION] && ( | ||
!MapManager::ExistMapAndVMap(530, 10349.6f, -6357.29f) || | ||
!MapManager::ExistMapAndVMap(530, -3961.64f, -13931.2f)))) | ||
{ | ||
exit(1); | ||
if (!sConfigMgr->isDryRun()) | ||
{ | ||
///- Check the existence of the map files for all races' startup areas. | ||
This conversation was marked as resolved
by FrancescoBorzi
Deku
Contributor
|
||
if (!MapManager::ExistMapAndVMap(0, -6240.32f, 331.033f) | ||
|| !MapManager::ExistMapAndVMap(0, -8949.95f, -132.493f) | ||
|| !MapManager::ExistMapAndVMap(1, -618.518f, -4251.67f) | ||
|| !MapManager::ExistMapAndVMap(0, 1676.35f, 1677.45f) | ||
|| !MapManager::ExistMapAndVMap(1, 10311.3f, 832.463f) | ||
|| !MapManager::ExistMapAndVMap(1, -2917.58f, -257.98f) | ||
|| (m_int_configs[CONFIG_EXPANSION] && ( | ||
!MapManager::ExistMapAndVMap(530, 10349.6f, -6357.29f) || | ||
!MapManager::ExistMapAndVMap(530, -3961.64f, -13931.2f)))) | ||
{ | ||
exit(1); | ||
} | ||
} | ||
|
||
///- Initialize pool manager | ||
@@ -1952,6 +1955,11 @@ void World::SetInitialWorldSettings() | ||
sLog->outString("Enabling database logging..."); | ||
sLog->SetLogDB(true); | ||
} | ||
|
||
if (sConfigMgr->isDryRun()) { | ||
sLog->outString("AzerothCore dry run completed, terminating."); | ||
exit(0); | ||
} | ||
} | ||
|
||
void World::DetectDBCLang() | ||
startup areas? rather starting zones, no ?
and just from reading the comment, what about using custom maps ? (i know we only do blizzlike but just curiosity)