Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/Battlegrounds): Enhanced bg system for modules #2334

Closed
wants to merge 10 commits into from

Conversation

Helias
Copy link
Member

@Helias Helias commented Oct 7, 2019

This PR allow to:

  • add other BGs as module that need to exchange data for "capture flags" or "assault base" and so on.
CHANGES PROPOSED:
  • restored old switch case related to 75bf44d
  • added hashmaps and conditions before several switch case
TESTS PERFORMED:
  • joined Warsong Gulch, Arathi Basin and played them until the end
  • joined different battlegrounds using Random Battleground

OS: Linux - Ubuntu 18.04.3 LTS

HOW TO TEST THE CHANGES:
  • join battlegrounds and finish it (capture the flag on Warsong Gulch, assault base on Arathi Basin etc.)
  • join also using random battleground
  • join some arenas and finish it

@Helias
Copy link
Member Author

Helias commented Oct 8, 2019

Still need to check different things, it is not ready.

@Helias
Copy link
Member Author

Helias commented Oct 9, 2019

To be honest, I don't really like the solution refactoring switch case into hashmaps, in these days I thinked about it and I find a solution.
It consists into adding hashmaps empty and if a module fill them the core will check and eventually use them, otherwise, it continue to use the switch case.

Indeed, I restored also the old switch case code (related to 75bf44d) to mantain the core TC-like ;-)

I tested this PR using two different mod-bg-*, to test this PR are not necessary the modules just test the normal battleground and arenas.

@Helias Helias changed the title Enhanced bg system for modules feat(Core/Battlegrounds): Enhanced bg system for modules Oct 25, 2019
@Helias
Copy link
Member Author

Helias commented Dec 21, 2019

This is now a duplicate of #2521
Hence, I'm closing it and deleting the branch, anyway test the new PR of Shard asap pls!

@Helias Helias closed this Dec 21, 2019
@Helias Helias deleted the enhance-bg-modules branch December 21, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant