-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Core/Battlegrounds) Reworked enhanced bg system for modules #2521
feat(Core/Battlegrounds) Reworked enhanced bg system for modules #2521
Conversation
@Endeffect-AT can you please have a look at this? |
Will test this and PR #1903 the next days, just need a little time |
I guess it's wip and i test it when ready 👍 |
@Endeffect-AT
It's not WIP, it's a finished PR haha |
I refer to the requested changes from @Viste |
…othcore-wotlk into enhanced-bg-system
Tested on win 10 pro 64 bit, AC commit 70170f0. Note: Didn't check the worldstates. P.S: ~ 4h Testing time BattlegroundsJoined & played every BG until the end from Random Queue:
Joined & played every BG until the end from Specific Queue:
Arenas rated (2v2)Team with ingame petition signed and joined every arena:
Arenas skirmish (2v2)Joined every arena in group:
ToDo - List:
Others:
|
Wow. Thanks a lot for taking that much time for testing, you're awesome @Endeffect-AT ! <3 It's weird that only "Isle of Conquest" have an issue with scoreboard, since this PR shouldn't touch at this... Can you try if you've the same error without the PR please ? About
This is not triggered by the PR. It's a random bug that AC have, I've reported this before : |
@Endeffect-AT great job! What a nice report. I don't think that any of the bugs that you mentioned have been introduced by this PR. For example, the Arathi Basin missing flag is an ancient bug that randomly happens and I usually clean my client cache to fix it |
Tested Isle of Conquest from Random Queue on master commit 0f590d0+ (Yes, i should update my core...) and the bug is the same. So your PR is working fine imo 👍 |
@Endeffect-AT |
@Endeffect-AT cool, thanks for checking that too. And good job @Shard-MW |
plz fix codestyle. |
Done, but I'll not change this : |
Reworked #2334
Special thanks to for his main PR @Helias <3
CHANGES PROPOSED:
TESTS PERFORMED:
HOW TO TEST THE CHANGES:
Target branch(es):
How to test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR