Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB/Locales: Add missing esES & esMX quest locales(Port from TC) #5483

Merged
merged 8 commits into from May 4, 2021
Merged

DB/Locales: Add missing esES & esMX quest locales(Port from TC) #5483

merged 8 commits into from May 4, 2021

Conversation

ernesto-glz
Copy link
Contributor

Changes Proposed:

  • Add Missing Spanish locales.

Tests Performed:

  • Tested on windows 10 and ubuntu 20.

How to Test the Changes:

  • To test these changes you must have the client in EsMX or EsES
  • .quest add quest_id verify that the texts are correctly translated and logically that the description is not empty.

Target Branch(es):

  • Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB label Apr 26, 2021
@ernesto-glz ernesto-glz changed the title DB/Locales: Add missing esES & esMX quest locales(Port from TC) DB/Locales: Add missing esES & esMX quest locales(Port from TC) [WIP] Apr 26, 2021
@Helias Helias reopened this Apr 26, 2021
@ernesto-glz
Copy link
Contributor Author

@Helias Thanks :)

@ernesto-glz ernesto-glz changed the title DB/Locales: Add missing esES & esMX quest locales(Port from TC) [WIP] DB/Locales: Add missing esES & esMX quest locales(Port from TC) Apr 26, 2021
Copy link
Member

@Kitzunu Kitzunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving blindly, but I trust you =D

@FrancescoBorzi FrancescoBorzi merged commit f96c528 into azerothcore:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants