[Core/Boss] Oculus/Orum, fix spawn mob position #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! we will test it soon. Please next time write the description in English or multi-lang in this repository :) |
DantestyleXD
added a commit
to DantestyleXD/azerothcore-wotlk
that referenced
this pull request
Aug 19, 2016
Closed
thanhtong89
pushed a commit
to thanhtong89/azerothcore-wotlk
that referenced
this pull request
Jul 28, 2019
Merge from Master Feb 09, 2018
Closed
This was referenced Sep 8, 2019
Closed
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Oct 14, 2020
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Nov 10, 2020
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Nov 10, 2020
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Dec 3, 2020
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Apr 5, 2021
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Apr 6, 2021
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Apr 12, 2021
mnclaras
referenced
this pull request
in mnclaras/azerothcore-wotlk
Apr 13, 2021
Closed
8 tasks
zTerragor
referenced
this pull request
in Legends-of-Azeroth/Legends-of-Azeroth-WoTLK-Core
Dec 7, 2021
Merged
neifion-00000000
pushed a commit
to neifion-00000000/azerothcore-wotlk
that referenced
this pull request
Jul 23, 2022
…e-suggestions Refactor instance suggestions
ohkasdasf
added a commit
to ohkasdasf/azerothcore-wotlk
that referenced
this pull request
Jan 11, 2023
Process of translation: only original sources of deDE texts by researching multiple sources, reverse translation by searching for related quest items/NPCs and using these names to reconstruct a proper translation. This fixes the terms Scrimshank (Kieselschliff), Banehollow (Schattenfluch), Trollbane (Trollbann), Stonesplitter (Splitterstein), Stonemaul (Steinbrecher), Captain (Hauptmann), Kromcrush (Krombruch), Earthbinder (Erdbinder), Razorfen (Klingenhauer), Razorflank (Klingenflanke), Stonard (Steinard) for quest progress/request text entries for the deDE localisation with proper casus/declension (these are not proper translated names of locations/NPCs that have been left over by Blizzard since their language localisations in TBC in 2006 and onward). Fixed a self-made translation for quest 334. Added missing deDE text entries for 4481, 4482, 4483, 5306, 5863, 7723, 9436.
Closed
Gultask
added a commit
that referenced
this pull request
Jan 24, 2023
Process of translation: only original sources of deDE texts by researching multiple sources, reverse translation by searching for related quest items/NPCs and using these names to reconstruct a proper translation. This fixes the terms Scrimshank (Kieselschliff), Banehollow (Schattenfluch), Trollbane (Trollbann), Stonesplitter (Splitterstein), Stonemaul (Steinbrecher), Captain (Hauptmann), Kromcrush (Krombruch), Earthbinder (Erdbinder), Razorfen (Klingenhauer), Razorflank (Klingenflanke), Stonard (Steinard) for quest progress/request text entries for the deDE localisation with proper casus/declension (these are not proper translated names of locations/NPCs that have been left over by Blizzard since their language localisations in TBC in 2006 and onward). Fixed a self-made translation for quest 334. Added missing deDE text entries for 4481, 4482, 4483, 5306, 5863, 7723, 9436. <!-- First of all, THANK YOU for your contribution. --> ## Changes Proposed: - Fixing missing or wrong entries in the quest_request_items_locale table. ## Issues Addressed: <!-- If your fix has a relating issue, link it below --> Fixes some of the tasks listed in the issues below: - #14244 - #14618 - From CC Github: chromiecraft/chromiecraft#4697 ## SOURCE: <!-- If you can, include a source that can strengthen your claim --> Read the text on top. ## Tests Performed: <!-- Does it build without errors? Did you test in-game? What did you test? On which OS did you test? Describe any other tests performed --> - Not tested. ## How to Test the Changes: <!-- Describe in a detailed step-by-step order how to test the changes --> All of the changes are to request texts of quests, can be tested by accepting quests or simply reviewing the changed file. ## Known Issues and TODO List: <!-- Is there anything else left to do after this PR? --> - [ ] I still might want to check which of the tasks in above mentioned issues are resolved by this. <!-- If you intend to contribute repeatedly to our project, it is a good idea to join our discord channel. We set ranks for our contributors and give them access to special resources or knowledge: https://discord.com/invite/DasJqPba) Do not remove the instructions below about testing, they will help users to test your PR --> ## How to Test AzerothCore PRs When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]**. You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here: http://www.azerothcore.org/wiki/How-to-test-a-PR **REMEMBER**: when testing a PR that changes something **generic** (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but **especially** check that the PR does not cause any regression (i.e. introducing new bugs). **For example**: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but **we should test Y and Z as well**. Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Tennesseej
pushed a commit
to Tennesseej/azerothcore-wotlk
that referenced
this pull request
Feb 27, 2023
…re#14619) Process of translation: only original sources of deDE texts by researching multiple sources, reverse translation by searching for related quest items/NPCs and using these names to reconstruct a proper translation. This fixes the terms Scrimshank (Kieselschliff), Banehollow (Schattenfluch), Trollbane (Trollbann), Stonesplitter (Splitterstein), Stonemaul (Steinbrecher), Captain (Hauptmann), Kromcrush (Krombruch), Earthbinder (Erdbinder), Razorfen (Klingenhauer), Razorflank (Klingenflanke), Stonard (Steinard) for quest progress/request text entries for the deDE localisation with proper casus/declension (these are not proper translated names of locations/NPCs that have been left over by Blizzard since their language localisations in TBC in 2006 and onward). Fixed a self-made translation for quest 334. Added missing deDE text entries for 4481, 4482, 4483, 5306, 5863, 7723, 9436. <!-- First of all, THANK YOU for your contribution. --> ## Changes Proposed: - Fixing missing or wrong entries in the quest_request_items_locale table. ## Issues Addressed: <!-- If your fix has a relating issue, link it below --> Fixes some of the tasks listed in the issues below: - azerothcore#14244 - azerothcore#14618 - From CC Github: chromiecraft/chromiecraft#4697 ## SOURCE: <!-- If you can, include a source that can strengthen your claim --> Read the text on top. ## Tests Performed: <!-- Does it build without errors? Did you test in-game? What did you test? On which OS did you test? Describe any other tests performed --> - Not tested. ## How to Test the Changes: <!-- Describe in a detailed step-by-step order how to test the changes --> All of the changes are to request texts of quests, can be tested by accepting quests or simply reviewing the changed file. ## Known Issues and TODO List: <!-- Is there anything else left to do after this PR? --> - [ ] I still might want to check which of the tasks in above mentioned issues are resolved by this. <!-- If you intend to contribute repeatedly to our project, it is a good idea to join our discord channel. We set ranks for our contributors and give them access to special resources or knowledge: https://discord.com/invite/DasJqPba) Do not remove the instructions below about testing, they will help users to test your PR --> ## How to Test AzerothCore PRs When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]**. You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here: http://www.azerothcore.org/wiki/How-to-test-a-PR **REMEMBER**: when testing a PR that changes something **generic** (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but **especially** check that the PR does not cause any regression (i.e. introducing new bugs). **For example**: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but **we should test Y and Z as well**. Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix che corregge il bug del boss Urom a Oculus, esso a ogni cambio piattaforma dovrebbe spawnare prima i mob e poi teletrasportarsi per ritornare off combat, invece ora come ora il boss si teletrasporta e spawna gli add sulla nuova piattaforma. Questo fa si che i mob arrivino dopo 30 sec sulla prima piattaforma fluttuando nell'aria.
Questo fix corregge il bug.
Google translator:
Fix that fixes the bug of Urom boss in Oculus , change it to any platform should spawn before the mobs and then teleport back off for combat , however right now the boss teleports and spawns the add on the new platform . This makes that the mob arrive after 30 sec on the first floating platform in the air .
This fix corrects the bug .