Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config.cmake not work. #989

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

AyaseCore
Copy link
Member

@AyaseCore AyaseCore commented Jul 28, 2018

fix: config.cmake not work.
conf/config.cmake.dist copy and rename to conf/config.cmake
conf/config.cmake is used to add custom cmake option.(look in

if(EXISTS "conf/config.cmake")
)
in fact, It should work.
But actually, it doesn't work.
The problem is that "EXISTS" cannot use relative paths.

CHANGES PROPOSED:

fix: config.cmake not work.

ISSUES ADDRESSED:

Closes
none

TESTS PERFORMED:

Don't need to test.

HOW TO TEST THE CHANGES:

Don't need to test.

KNOWN ISSUES AND TODO LIST:

none

  • [ ]
  • [ ]
Target branch(es):

Master

@BarbzYHOOL
Copy link
Member

What was the issue?

@AyaseCore
Copy link
Member Author

conf/config.cmake.dist copy and rename-> conf/config.cmake.
It is used to add custom options.(but it not work.)

Problem discovered by accident.
Fixed by the way.
It shouldn't need testing. It's just a minor problem.

@BarbzYHOOL

@BarbzYHOOL BarbzYHOOL merged commit 334a0f3 into azerothcore:master Aug 6, 2018
@BarbzYHOOL
Copy link
Member

ty @AyaseCore ;)

@AyaseCore AyaseCore deleted the AyaseCore-patch-1 branch August 7, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants