Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core): Achievements #47

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

noisiver
Copy link

  • Added AchievementMethods
  • Added GetId to AchievementMethods
  • Added OnAchiComplete to PlayerHooks

Tested with:

local PLAYER_ON_ACHIEVEMENT_COMPLETE = 45

local function OnAchiComplete(event, player, achievement)
    print(player:GetName()..' has completed achievement with id '..achievement:GetId())
end
RegisterPlayerEvent(PLAYER_ON_ACHIEVEMENT_COMPLETE, OnAchiComplete)

Note: I wanted to add GetName() to AchievementMethods but locale kept causing a segmentation fault so I'm holding off on that for now

@noisiver noisiver changed the title Feat: Achievements feat(Core): Achievements Jun 26, 2022
@55Honey
Copy link
Member

55Honey commented Jul 5, 2022

Tested, works as intended.

@55Honey 55Honey merged commit efba901 into azerothcore:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants