一些更新 #166
Closed
一些更新 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README-EN.md # README.md # app/src/main/java/com/azhon/app/MainActivity.kt # appupdate/src/main/AndroidManifest.xml # appupdate/src/main/java/com/azhon/appupdate/view/UpdateDialogActivity.kt # build.gradle
|
很遗憾的告知您，您此次的PR与本项目设计的初心相悖；本项目致力于成为一个小而美的的版本更新模块，所以内置只有一个通用的对话框样式，如果未能满足您的需求您可以参考Demo中【使用自己的对话框更新】进行使用，毕竟内置再多的对话框样式也不能满足所有的用户。 |
|
你想要小而美？我讨厌张小龙。
理念确实不和。
而且你没有审查代码。
…________________________________
From: Code Porter ***@***.***>
Sent: Monday, June 3, 2024 9:10:04 PM
To: azhon/AppUpdate ***@***.***>
Cc: Knightwood ***@***.***>; Author ***@***.***>
Subject: Re: [azhon/AppUpdate] 一些更新 (PR #166)
很遗憾的告知您，您此次的PR与本项目设计的初心相悖；本项目致力于成为一个小而美的的版本更新模块，所以内置只有一个通用的对话框样式，如果未能满足您的需求您可以参考Demo中【使用自己的对话框更新】进行使用，毕竟内置再多的对话框样式也不能满足所有的用户。
―
Reply to this email directly, view it on GitHub<#166 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIBVF2CA3TPRTPLZ36TNEBDZFRTKZAVCNFSM6AAAAABIWI63ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGE3DKNRTGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
代码已经看过了；作为一个库，被大量使用是需要全盘考虑的。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle更新到8.5
添加了几种更新界面，由dialog和dialogfragment实现，原有界面增加了一点尺寸适配
改进的配置方法，将界面分离，可以更方便定制ui
下载的时候隐藏界面后，重新显示界面而不重新下载
修改了下载路径，添加一层，方便删除文件