Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated functions #241

Merged
merged 1 commit into from
Oct 29, 2021
Merged

chore: remove deprecated functions #241

merged 1 commit into from
Oct 29, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Oct 29, 2021

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity labels Oct 29, 2021
@azjezz azjezz added this to the 2.0.0 milestone Oct 29, 2021
@azjezz azjezz self-assigned this Oct 29, 2021
@azjezz azjezz force-pushed the chore/remove-deprecated-functions branch 6 times, most recently from cd073ad to 04f0b27 Compare October 29, 2021 22:39
@coveralls
Copy link

coveralls commented Oct 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1400999724

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 100.0%
Totals Coverage Status
Change from base Build 1400779609: 0.06%
Covered Lines: 2802
Relevant Lines: 2802
💛 - Coveralls

@azjezz azjezz force-pushed the chore/remove-deprecated-functions branch 8 times, most recently from b65c8cb to c612f5d Compare October 29, 2021 23:16
azjezz
azjezz commented Oct 29, 2021
View reviewed changes
src/Psl/Iter/reduce_keys.php
Comment on lines -31 to +33
* @return Ts|null
* @return Ts
*/
function reduce_keys(iterable $iterable, callable $function, $initial = null)
function reduce_keys(iterable $iterable, callable $function, mixed $initial): mixed
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @veewee ;)

@azjezz azjezz force-pushed the chore/remove-deprecated-functions branch 7 times, most recently from 97035c8 to e8bbbf4 Compare October 29, 2021 23:44
@azjezz
chore: remove deprecated functions
db095ff 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the chore/remove-deprecated-functions branch from e8bbbf4 to db095ff Compare October 29, 2021 23:46
@azjezz azjezz mentioned this pull request Oct 29, 2021
Closed
@azjezz azjezz merged commit da87d8b into 2.0.x Oct 29, 2021
@azjezz azjezz deleted the chore/remove-deprecated-functions branch October 29, 2021 23:54
@azjezz azjezz mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls