Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mixed dict and vec types #362

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add mixed dict and vec types #362

merged 1 commit into from
Nov 4, 2022

Conversation

BackEndTea
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 26, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3392156771

  • 31 of 31 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 98.939%
Totals Coverage Status
Change from base Build 3392126642: 0.01%
Covered Lines: 3357
Relevant Lines: 3393
💛 - Coveralls

@azjezz azjezz added this to the 2.1.0 milestone Aug 28, 2022
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. Type: Enhancement Most issues will probably ask for additions or changes. labels Aug 28, 2022
@azjezz
Copy link
Owner

azjezz commented Aug 28, 2022

LGTM, can you rebase this against 2.1.x? ( see #361 )

@jrmajor
Copy link
Contributor

jrmajor commented Aug 29, 2022

What would be the difference between T\vec(T\mixed()) and T\mixed_vec()?

@BackEndTea
Copy link
Contributor Author

What would be the difference between T\vec(T\mixed()) and T\mixed_vec()?

Better performance, this won't loop over the entire array if its not needed.

Se also #359

@BackEndTea @azjezz
Add mixed dict and vec types
a9f3571 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz merged commit 66e5351 into azjezz:2.1.x Nov 4, 2022
@azjezz
Copy link
Owner

azjezz commented Nov 4, 2022

Thanks @BackEndTea

@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. labels Nov 4, 2022
@BackEndTea BackEndTea deleted the mixed/dict-vec branch November 4, 2022 08:06
@BackEndTea
Copy link
Contributor Author

Thanks @azjezz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@BackEndTea BackEndTea

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BackEndTea @coveralls @azjezz @jrmajor