Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use array_is_list for vec types #364

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Use array_is_list for vec types #364

merged 1 commit into from
Nov 4, 2022

Conversation

BackEndTea
Copy link
Contributor

This simplifies the code in the VecType, and slighly reduces overhead for the unhappy path.

@coveralls
Copy link

coveralls commented Sep 4, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3392116340

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.929%
Totals Coverage Status
Change from base Build 3392109903: -0.003%
Covered Lines: 3326
Relevant Lines: 3362
💛 - Coveralls

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. Type: Enhancement Most issues will probably ask for additions or changes. labels Nov 4, 2022
@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. labels Nov 4, 2022
@azjezz
Copy link
Owner

azjezz commented Nov 4, 2022

Thanks @BackEndTea

@azjezz azjezz merged commit d1f0c05 into azjezz:2.1.x Nov 4, 2022
@BackEndTea BackEndTea deleted the chore/array_is_list branch November 4, 2022 08:07
@BackEndTea
Copy link
Contributor Author

Thanks @azjezz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@BackEndTea BackEndTea

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BackEndTea @coveralls @azjezz