Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(type): Introduce type constructor purity #461

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat(type): Introduce type constructor purity #461

merged 1 commit into from
Apr 5, 2024

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Apr 5, 2024

Partially solves #130 : The Type\xxx() functions are now considered pure.
coerce() and assert() can still not be marked as pure for every type (given impure iterable issues)

@coveralls
Copy link

coveralls commented Apr 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8569984484

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.781%
Totals Coverage Status
Change from base Build 8565478656: 0.0%
Covered Lines: 4377
Relevant Lines: 4431
💛 - Coveralls

@veewee veewee requested a review from azjezz April 5, 2024 12:43
@veewee veewee added Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes. labels Apr 5, 2024
@veewee veewee added this to the 3.0.0 milestone Apr 5, 2024
@azjezz
Copy link
Owner

azjezz commented Apr 5, 2024

could we also mark all classes as readonly?

azjezz
azjezz approved these changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@azjezz azjezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will leave readonly for another PR. this is okay on its own.

@azjezz azjezz merged commit 5ab5416 into azjezz:next Apr 5, 2024
14 checks passed
@veewee
Copy link
Collaborator Author

veewee commented Apr 5, 2024

oh yeah I forgot about that ! :) Maybe next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@veewee @coveralls @azjezz