Change Iter\apply (Closure(T): void) $function to (Closure(T): mixed)
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mixed)`
If the return type is not going to be used, it does not make sense to enforce it.
For example, there are cases like arrow functions that are incompatible, and force to use longer versions just because of the implicit return, for example:
```php
Psl\Iter\apply(
$items,
fn (Item $item) => $q($item)->then($this->processItem(...))
);
```
devnix
changed the title
Iter\apply (Closure(T): void) $functionto (Closure(T): mixed)Iter\apply (Closure(T): void) $function to (Closure(T): mixed)
Pull Request Test Coverage Report for Build 8780834876Details
💛 - Coveralls |
veewee
approved these changes
Apr 25, 2024
veewee
added
Priority: Medium
azjezz
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the return type is not going to be used, it does not make sense to enforce it.
For example, there are cases like arrow functions that are incompatible, and force to use longer versions just because of the implicit return, for example: