Store volume in the config file, write the config file, fixes #22
Conversation
| @@ -184,6 +184,7 @@ def message_received(self, text): | |||
| self.volume = float(float(parameter) / 100) | |||
| self.send_msg_channel(var.config.get('strings', 'change_volume') % ( | |||
| int(self.volume * 100), self.mumble.users[text.actor]['name'])) | |||
| var.config.set('bot', 'volume', str(self.volume)) | |||
There was a problem hiding this comment.
Not sure about this one. You can have the "jerks people" who set the bot volume at 100%.
There was a problem hiding this comment.
You can still !v 100 though, this doesn't really enable it any easier. Personally I've not had a problem on my server and having to set the bot volume again each restart even if restarts are far apart seems to me more annoying long term.
EDIT: Of course you could make this an option, but that does sound kind of redundant to me if anyone is able to change the volume anyways. Should I make a config option for a max volume the bot will ever refuse to go realtime or config?
EDIT2: Also isn't this kind of solved through user ignoring that I suggested ;) Also fyi I am kind of going through a family emergency for a few days so I may not be responding that quickly if at all for a few days here
Fixes commands failing because of repeat missing from the config.
Fixes bot startup without specifying --user
Implements a function to write the configuration file on exit, stores the volume to the config when it is changed.