Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Fix logfile rotation (small fix) #308

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix logfile rotation (small fix) #308

merged 1 commit into from
Jan 21, 2022

Conversation

KrakatauiHD
Copy link
Contributor

Without the backupCount value, the logfile would never be rotated and will grow infinitely.
As a sidenote: the web-logs will grow pretty fast - in my experience, when the webinterface is open 10KB/5min, so 10KB might be a bit small for the webserver logs.

@azlux
Copy link
Owner

azlux commented Jan 20, 2022

Thank for the fix
You think we should increase the max size to 1-5Mo ?

@KrakatauiHD
Copy link
Contributor Author

Yes, probably somewhere in that range. And maybe even create a configuration-file option for the size / backupCounts.

@azlux
Copy link
Owner

azlux commented Jan 20, 2022

no, I think we have enought option

@TerryGeng
Copy link
Collaborator

I think we need to add a config option to define the number of log files to keep. I will take that over.

@hamilton5
Copy link

Why wouldn't people be utilizing logrotate that is already on most linux systems? And if we do, if the log file is modified externally does the bot need to be restarted ?

@TerryGeng
Copy link
Collaborator

Why wouldn't people be utilizing logrotate that is already on most linux systems? And if we do, if the log file is modified externally does the bot need to be restarted ?

I do logrotate personally. But this feature has been here for a long time... I don't know whether to drop it in the future since it may hurt some users.

@hamilton5
Copy link

hamilton5 commented Jan 24, 2022

How do you do that? How is this feature disabled entirely? Seems to be hard coded? 10KB is extremely small. I'm at about 500KB after 3 days of continuous playing the same list(the duplicate entries don't help)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants