Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user friendly errors using miette, gated by "error_reporting" feature #40

Merged
merged 7 commits into from
Oct 23, 2022

Conversation

azriel91
Copy link
Owner

Part of #28.

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 93.84% // Head: 92.68% // Decreases project coverage by -1.15% ⚠️

Coverage data is based on head (78f356e) compared to base (3b58840).
Patch coverage: 2.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   93.84%   92.68%   -1.16%     
==========================================
  Files         121      121              
  Lines        6875     6962      +87     
==========================================
+ Hits         6452     6453       +1     
- Misses        423      509      +86     
Impacted Files Coverage Δ
crate/rt_model_native/src/error.rs 50.00% <0.00%> (-50.00%) ⬇️
workspace_tests/src/vec_copy_item_spec.rs 87.23% <ø> (ø)
crate/rt/src/cmds/sub/states_current_read_cmd.rs 41.37% <2.29%> (-58.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 force-pushed the feature/28/cli-output-error-reporting branch from fc451ad to be84132 Compare October 20, 2022 19:38
@azriel91 azriel91 force-pushed the feature/28/cli-output-error-reporting branch from be84132 to 1170f58 Compare October 20, 2022 19:45
@azriel91 azriel91 force-pushed the feature/28/cli-output-error-reporting branch from 98017cb to d563834 Compare October 23, 2022 02:19
@azriel91 azriel91 force-pushed the feature/28/cli-output-error-reporting branch from d563834 to 019795e Compare October 23, 2022 02:36
@azriel91 azriel91 marked this pull request as ready for review October 23, 2022 02:42
@azriel91 azriel91 merged commit a6201e6 into main Oct 23, 2022
@azriel91 azriel91 deleted the feature/28/cli-output-error-reporting branch October 23, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant