Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rover --clone to bring landing zones dependencies #56

Closed
LaurentLesle opened this issue Jul 17, 2020 · 0 comments · Fixed by #60
Closed

Add rover --clone to bring landing zones dependencies #56

LaurentLesle opened this issue Jul 17, 2020 · 0 comments · Fixed by #60
Assignees
@LaurentLesle
Labels
enhancement New feature or request

Comments

@LaurentLesle
Copy link
Contributor

Rover clone is used to bring the landing zones dependencies you need to deploy your landing zone

By default the rover will clone the azure/caf-terraform-landingzones into the local rover folder /tf/caf/landinzones

Examples:
- Clone the launchpad: rover --clone-folder /landingzones/launchpad
- Clone the launchpad in different folder: rover --clone-destination /tf/caf/landingzones/public --clone-folder /landingzones/launchpad
- Clone the launchpad (branch vnext): rover --clone-folder-strip 2 --clone-destination /tf/rover/landingzones --clone-folder /landingzones/launchpad --clone-branch vnext

- Clone the CAF foundations landingzone: rover --clone-folder /landingzones/landingzone_caf_foundations
- Clone the AKS landingzone: rover --clone aztfmod/landingzone_aks --clone-destination /tf/caf/landingzones/landingzone_aks

--clone-branch set the branch to pull the package.
By default is not set use the master branch.

--clone-destination change the destination local folder.
By default clone the package into the /tf/caf/landingzones folder of the rover

--clone-folder specify the folder to extract from the original project

  Example: --clone-folder /landingzones/landingzone_caf_foundations will only extract the caf foundations landing zone

--clone-folder-strip is used strip the base folder structure from the original folder

  In the GitHub package of azure/caf-terraform-landingzones, the data are packaged in the following structure
  caf-terraform-landingzones-master/landingzones/launchpad/main.tf
  [project]-[branch]/landgingzones/[landingzone]
  To reproduce a nice folder structure in the rover it it possible to set the --clone-folder-strip to 2 to remove [project]-[branch]/landingzones and only retrieve the third level folder

  Default to 2 when using azure/caf-terraform-landingzones and 1 for all other git projects

--clone specify a GitHub organization and project in the for org/project
The default setting if not set is azure/caf-terraform-landingzones
LaurentLesle added a commit that referenced this issue Jul 17, 2020
@LaurentLesle
#56
08f3e08
@arnaudlh arnaudlh added the enhancement New feature or request label Jul 23, 2020
@arnaudlh arnaudlh linked a pull request Jul 24, 2020 that will close this issue
2007 #60
Merged
arnaudlh added a commit that referenced this issue Jul 24, 2020
@LaurentLesle @arnaudlh
2007 (#60)
e75b6fa 
* Add support for TF013 beta 3

* Remove workspace and transition settings
to devcontainer

* Add --clone-launchpad

* Remove --clone-error writing to stdout
download progress

* Remove launchpad command
Remove launchpad landing zone from rover

* Cleanup dockerfile

* Refactor the command logic for more scalability

* Fix a destroy condition

* Fix command conditions + cleanup

* Fix rover clone

* Fix a CI destroy condition

* #56

* Add ssh server for Azure aci

* Updating port for Azure bastion

* Fix sshd port to 22 for aci

* Regenerate sshd keys if missing

* Make the sshd.sh executable

* Run sshd in non-root container

* Fix docker in non-root mode

* Upgrade tools version
Cleanup variables

* Remove password for ssh
Change ssh server config

* Add terraform 0.12.29

* Add 0.13.0-rc1 docker image

* Update changelog.md

* Update changelog.md

Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
Co-authored-by: lolorol <lalesle@microsoft.com>
LaurentLesle added a commit that referenced this issue Sep 2, 2020
@LaurentLesle @arnaudlh
August release (#64)
efdac1a 
* Add support for TF013 beta 3

* Remove workspace and transition settings
to devcontainer

* Add --clone-launchpad

* Remove --clone-error writing to stdout
download progress

* Remove launchpad command
Remove launchpad landing zone from rover

* Cleanup dockerfile

* Refactor the command logic for more scalability

* Fix a destroy condition

* Fix command conditions + cleanup

* Fix rover clone

* Fix a CI destroy condition

* #56

* Add ssh server for Azure aci

* Updating port for Azure bastion

* Fix sshd port to 22 for aci

* Regenerate sshd keys if missing

* Make the sshd.sh executable

* Run sshd in non-root container

* Fix docker in non-root mode

* Upgrade tools version
Cleanup variables

* Remove password for ssh
Change ssh server config

* Add terraform 0.12.29

* Add 0.13.0-rc1 docker image

* Update changelog.md

* Update changelog.md

* Update rover to version 13 GA

Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
Co-authored-by: lolorol <lalesle@microsoft.com>
arnaudlh added a commit that referenced this issue Oct 1, 2020
@LaurentLesle @arnaudlh
Vnext (#71)
a84577a 
* Add support for TF013 beta 3

* Remove workspace and transition settings
to devcontainer

* Add --clone-launchpad

* Remove --clone-error writing to stdout
download progress

* Remove launchpad command
Remove launchpad landing zone from rover

* Cleanup dockerfile

* Refactor the command logic for more scalability

* Fix a destroy condition

* Fix command conditions + cleanup

* Fix rover clone

* Fix a CI destroy condition

* #56

* Add ssh server for Azure aci

* Updating port for Azure bastion

* Fix sshd port to 22 for aci

* Regenerate sshd keys if missing

* Make the sshd.sh executable

* Run sshd in non-root container

* Fix docker in non-root mode

* Upgrade tools version
Cleanup variables

* Remove password for ssh
Change ssh server config

* Add terraform 0.12.29

* Add 0.13.0-rc1 docker image

* Update changelog.md

* Update changelog.md

* Update rover to version 13 GA

* Create .gitattributes

* Improvements to support multi layers and sub

* Fix plugin-cache creation

* Fix plug-in folder creation

* Add rover import and state list
Add build local image

* Fix minor upgrade for azcli and tfdoc

* Add Ansible

* Adding codespaces support (#72)

Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
Co-authored-by: lolorol <lalesle@microsoft.com>
arnaudlh added a commit that referenced this issue Oct 28, 2020
@LaurentLesle @arnaudlh
October release (#82)
9a050f1 
* Add support for TF013 beta 3

* Remove workspace and transition settings
to devcontainer

* Add --clone-launchpad

* Remove --clone-error writing to stdout
download progress

* Remove launchpad command
Remove launchpad landing zone from rover

* Cleanup dockerfile

* Refactor the command logic for more scalability

* Fix a destroy condition

* Fix command conditions + cleanup

* Fix rover clone

* Fix a CI destroy condition

* #56

* Add ssh server for Azure aci

* Updating port for Azure bastion

* Fix sshd port to 22 for aci

* Regenerate sshd keys if missing

* Make the sshd.sh executable

* Run sshd in non-root container

* Fix docker in non-root mode

* Upgrade tools version
Cleanup variables

* Remove password for ssh
Change ssh server config

* Add terraform 0.12.29

* Add 0.13.0-rc1 docker image

* Update changelog.md

* Update changelog.md

* Update rover to version 13 GA

* Create .gitattributes

* Improvements to support multi layers and sub

* Fix plugin-cache creation

* Fix plug-in folder creation

* Add rover import and state list
Add build local image

* Fix minor upgrade for azcli and tfdoc

* Add Ansible

* Adding codespaces support (#72)

* Updating tools version

* Add ansible

* Multi-layer support for 0.4

* Add -var-folder support

* Remove constrain to run vscode with logged-in user

* Fix execution with msi

* Set Tenant_ID when using MSI

* fix ARM_TENANT_ID

* Add support for Packer

* Add yq to parse yaml files

* Add rover version verification in vscode

* Update devcontainer version

* Update yaml to addess Github env variable change

* Fix merge in dockerfile

* Fix tfsec

* Fix a merge issue with ansible

* Fix a permission denied in vscode

* Set TF_VAR_tenant_id when executed by non user

* Fix environment variable for launchpad init

* Update rover verify function

* Remove version verification in pipelines

* Add support for multiple var-folder parameters

* Hotfix to prevent duplicates when using var-folder
nultiple times

* Update docker-compose.yml

* Add git pre-commit

* Update terraform to 0.13.4
Update AzureCli to 2.14.0

* Update ci

* Update vnext trigger

Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
Co-authored-by: lolorol <lalesle@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LaurentLesle LaurentLesle

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2007 aztfmod/rover
2 participants
@LaurentLesle @arnaudlh