Skip to content
This repository has been archived by the owner on Aug 18, 2022. It is now read-only.

Use .rover directory for everything where we can, inlcuding TF_DATA_DIR #35

Closed
benc-uk opened this issue Jun 3, 2021 · 1 comment
Closed

Use .rover directory for everything where we can, inlcuding TF_DATA_DIR #35

benc-uk opened this issue Jun 3, 2021 · 1 comment
Assignees
@PaulDFoster
Labels
easy 😁 rover-go Reimplement rover in Go
Milestone
MVP Release

Comments

@benc-uk
Copy link
Collaborator

benc-uk commented Jun 3, 2021 •
edited
Loading

Suggestion we use a $HOME/.rover for everything we can

  • TF_DATA_DIR
  • rover config file
  • tmp stuff
  • tfstate & plan storage
  • ci_tasks folder
  • tfstates folder (currently in $HOME)
  • Also logs e.g. $HOME/.rover/logs/
  • Place command history here e.g. $HOME/.rover/hist.txt
@benc-uk benc-uk added easy 😁 rover-go Reimplement rover in Go labels Jun 3, 2021
@PaulDFoster PaulDFoster self-assigned this Jun 8, 2021
@sebastus sebastus mentioned this issue Jun 8, 2021
Closed
@benc-uk benc-uk added this to the MVP Release milestone Jun 9, 2021
@benc-uk
Copy link
Collaborator Author

benc-uk commented Jun 9, 2021

@PaulDFoster We might want to chat about this, just thinking for the first time run, say we create a new .rover dir in user's home, that's all fine, but how do we get ci_tasks in there? And populate it with the default or "out of the box" task definition files

PaulDFoster added a commit that referenced this issue Jun 11, 2021
@PaulDFoster
Use .rover directory for everything where we can, inlcuding TF_DATA_DIR
14e41d7 
Fixes #35
refactored home directory creation + test into utils function for reuse
@PaulDFoster PaulDFoster mentioned this issue Jun 11, 2021
Merged
PaulDFoster added a commit that referenced this issue Jun 11, 2021
@PaulDFoster
Use .rover directory for everything where we can, inlcuding TF_DATA_DIR
43e2901 
Fixes #35 implemented PR suggestions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PaulDFoster PaulDFoster

Labels
easy 😁 rover-go Reimplement rover in Go
Projects
None yet
Milestone
MVP Release
Development

No branches or pull requests
2 participants
@benc-uk @PaulDFoster