Use NSCalendar instead of custom defines where possible #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knellr Great Work! |
akuraru
added a commit
that referenced
this pull request
Mar 21, 2015
Use NSCalendar instead of custom defines where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the daylight savings issue discussed in #23 and partially addressed in #24, this proposal converts the existing code to use
NSCalendarinstead of #defines.Specifically, this addresses a discrepancy between
dateWithDaysFromNow:, which used the constants, anddateByAddingDays:, which used the calendar. These would have returned different results at the start of daylight savings time.