append dirname of tsconfigPath to project reference paths #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisyscanner
force-pushed
the
use-tsconfigpath-dir-for-ref-paths
branch
from
8738d36
to
ca5e290
Compare
azu
reviewed
Jan 17, 2021
There was a problem hiding this comment.
Thanks! LGTM
Can you add a test?
- Create(copy) your expected structure into https://github.com/azu/monorepo-utils/tree/master/packages/%40monorepo-utils/workspaces-to-typescript-project-references/test/fixtures
- Add test case with
checkOnly: trueto https://github.com/azu/monorepo-utils/blob/master/packages/%40monorepo-utils/workspaces-to-typescript-project-references/test/index.test.ts
This test works as Snapshot Testing-like testing.
| @@ -52,24 +55,26 @@ export const toProjectReferences = (options: Options) => { | |||
| if (!absolutePathOrNull) { | |||
| return; | |||
| } | |||
| if (!path.isAbsolute(absolutePathOrNull)) { | |||
| const tsConfigDirName = path.dirname(options.tsConfigPath ?? DEFAULT_TSCONFIGPATH); | |||
| const absolutePath = path.join(absolutePathOrNull, tsConfigDirName); | |||
There was a problem hiding this comment.
> require("path").dirname("tsconfig.json")
'.'
> require("path").join("a", ".")
'a'
aha. it will work correctly.
noisyscanner
force-pushed
the
use-tsconfigpath-dir-for-ref-paths
branch
from
ca5e290
to
8bb4f76
Compare
|
Sorted @azu :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38