Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock.SetMaxFrameRate potentially causing jitter when VSync not available #154

Open
slimsag opened this issue Mar 20, 2016 · 1 comment
Open

Clock.SetMaxFrameRate potentially causing jitter when VSync not available #154

slimsag opened this issue Mar 20, 2016 · 1 comment

Comments

@slimsag
Copy link
Member

slimsag commented Mar 20, 2016

TODO(slimsag): investigate.
@slimsag
Copy link
Member Author

slimsag commented Mar 20, 2016

Tried disabling on a system without vsync, but it looks like there is no difference (still should investigate improvements here)

slimsag added a commit to slimsag/nintengo that referenced this issue Mar 25, 2016
@slimsag
nes: do not needlessly set Clock.SetMaxFrameRate
f893fd1 
At the very best, this is by default 75FPS and doesn't affect anything
because of VSync anyway. At the very worst, setting it to the same as
desired framerate (and not higher) [could be harmful](azul3d/engine#154).

The default is probably always good enough for Nintengo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slimsag