Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery enhancements #2

Closed
uday31in opened this issue Jun 15, 2020 · 1 comment · Fixed by #65
Closed

Discovery enhancements #2

uday31in opened this issue Jun 15, 2020 · 1 comment · Fixed by #65

Comments

@uday31in
Copy link
Member

uday31in commented Jun 15, 2020 •
edited by ljtill
Loading

Support Discovery in environment with duplicate display name for management group and subscription
@ljtill ljtill added the enhancement New feature or request label Jun 15, 2020
@ljtill ljtill changed the title Support Discovery in environment with duplicate display name for management group and subscription Support discovery with duplicate display name Jun 29, 2020
@daltondhcp daltondhcp changed the title Support discovery with duplicate display name Discovery enhancements - Scoped Discovery, Duplicate Subscription Names and Discovery Deny / Exclusion list Jul 2, 2020
@daltondhcp daltondhcp changed the title Discovery enhancements - Scoped Discovery, Duplicate Subscription Names and Discovery Deny / Exclusion list Discovery enhancements Jul 2, 2020
@daltondhcp
Copy link
Contributor

  • Support Partial Discovery with SPN not having full access at root (with override)
  • Allow Duplicate names for MG and Subscription (with override in azops.yml)
  • Discovery Deny list of Subscription/MG path for discovery (in Enterprise-Scale) in .gitignore style (.azopsignore???)

@daltondhcp daltondhcp linked a pull request Jul 7, 2020 that will close this issue
[Feature] Discovery enhancements #65
Merged
ljtill added a commit that referenced this issue Jul 16, 2020
@matt-FFFFFF @ljtill
@krowlandson @uday31in
Support Azure DevOps (#19)
72a5b5a 
* AzOps pipeline

[skip ci]

* Move pipeline

* Merged PR 20: Use ADO APIs

Related work items: #85, #86, #87, #88

* Merged PR 21: Revert 'Use ADO APIs'

Reverts !20

* Ado (#2)

* Reset AzOps pipeline

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update *.parameters.json location (#7)

* Update *.parameters.json location

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Enable parallel jobs in pipeline (#10)

* Update pipeline to allow parallel test runs

* Add variables for important values

* Added dependsOn for 2nd stage jobs

* Update timeoutInMinutes variable

* Remove quotes from PSVersionTable

* Move environment configuration to script

* Move Initialize-AzOpsTestEnvironment to /test/scripts/ folder

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing azops reference folder (#12)

* removing azopsreference

* changing variable name to AzOpsReferenceFolder

* changing Write-Ouput to Write-AzOpsLog

* adding AzOps Log

* Move pipeline

* Reset AzOps pipeline

* AzOps pipeline

[skip ci]

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing stong type from save-azopsmg (#13)

* Update container tag

* Moar variables

* Create ado specific comment

* Add replaceme tags

Co-authored-by: Matt White <mawhi@microsoft.com>
Co-authored-by: Matt White <Matthew.White@microsoft.com>
Co-authored-by: Lyon J Till <158992+ljtill@users.noreply.github.com>
Co-authored-by: Kevin Rowlandson <kevin.rowlandson@monoconsultancy.com>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>

* AzOps pipeline

[skip ci]

* Move pipeline

* Merged PR 20: Use ADO APIs

Related work items: #85, #86, #87, #88

* Merged PR 21: Revert 'Use ADO APIs'

Reverts !20

* Ado (#2)

* Reset AzOps pipeline

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update *.parameters.json location (#7)

* Update *.parameters.json location

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Enable parallel jobs in pipeline (#10)

* Update pipeline to allow parallel test runs

* Add variables for important values

* Added dependsOn for 2nd stage jobs

* Update timeoutInMinutes variable

* Remove quotes from PSVersionTable

* Move environment configuration to script

* Move Initialize-AzOpsTestEnvironment to /test/scripts/ folder

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing azops reference folder (#12)

* removing azopsreference

* changing variable name to AzOpsReferenceFolder

* changing Write-Ouput to Write-AzOpsLog

* adding AzOps Log

* Move pipeline

* Reset AzOps pipeline

* AzOps pipeline

[skip ci]

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing stong type from save-azopsmg (#13)

* Update container tag

* Moar variables

* Create ado specific comment

* Add replaceme tags

Co-authored-by: Matt White <mawhi@microsoft.com>
Co-authored-by: Matt White <Matthew.White@microsoft.com>
Co-authored-by: Lyon J Till <158992+ljtill@users.noreply.github.com>
Co-authored-by: Kevin Rowlandson <kevin.rowlandson@monoconsultancy.com>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>

* title & & body for ADO PR

* Remove INPUT prefix from SCMPLATFORM variable name

* Use  $(Build.SourceBranchName) for docker tag

* Updated AzOpsDockerBuild.yml

* Fix env var name

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Add replaceme tags

* Correct GH references

* Remove as this is now included upstream

* Remove explicit -Verbose

* Add Out-Nulls to REST requests

* Remove null redirects

Co-authored-by: Matt White <Matthew.White@microsoft.com>
Co-authored-by: Matt White <mawhi@microsoft.com>
Co-authored-by: Lyon J Till <158992+ljtill@users.noreply.github.com>
Co-authored-by: Kevin Rowlandson <kevin.rowlandson@monoconsultancy.com>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>
ljtill added a commit that referenced this issue Aug 6, 2020
@ljtill @matt-FFFFFF
@krowlandson @uday31in
Add Azure DevOps support (#125)
c7723f2 
* Support Azure DevOps (#19)

* AzOps pipeline

[skip ci]

* Move pipeline

* Merged PR 20: Use ADO APIs

Related work items: #85, #86, #87, #88

* Merged PR 21: Revert 'Use ADO APIs'

Reverts !20

* Ado (#2)

* Reset AzOps pipeline

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update *.parameters.json location (#7)

* Update *.parameters.json location

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Enable parallel jobs in pipeline (#10)

* Update pipeline to allow parallel test runs

* Add variables for important values

* Added dependsOn for 2nd stage jobs

* Update timeoutInMinutes variable

* Remove quotes from PSVersionTable

* Move environment configuration to script

* Move Initialize-AzOpsTestEnvironment to /test/scripts/ folder

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing azops reference folder (#12)

* removing azopsreference

* changing variable name to AzOpsReferenceFolder

* changing Write-Ouput to Write-AzOpsLog

* adding AzOps Log

* Move pipeline

* Reset AzOps pipeline

* AzOps pipeline

[skip ci]

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing stong type from save-azopsmg (#13)

* Update container tag

* Moar variables

* Create ado specific comment

* Add replaceme tags

Co-authored-by: Matt White <mawhi@microsoft.com>
Co-authored-by: Matt White <Matthew.White@microsoft.com>
Co-authored-by: Lyon J Till <158992+ljtill@users.noreply.github.com>
Co-authored-by: Kevin Rowlandson <kevin.rowlandson@monoconsultancy.com>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>

* AzOps pipeline

[skip ci]

* Move pipeline

* Merged PR 20: Use ADO APIs

Related work items: #85, #86, #87, #88

* Merged PR 21: Revert 'Use ADO APIs'

Reverts !20

* Ado (#2)

* Reset AzOps pipeline

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update *.parameters.json location (#7)

* Update *.parameters.json location

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update ubuntu-latest.yml

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Enable parallel jobs in pipeline (#10)

* Update pipeline to allow parallel test runs

* Add variables for important values

* Added dependsOn for 2nd stage jobs

* Update timeoutInMinutes variable

* Remove quotes from PSVersionTable

* Move environment configuration to script

* Move Initialize-AzOpsTestEnvironment to /test/scripts/ folder

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing azops reference folder (#12)

* removing azopsreference

* changing variable name to AzOpsReferenceFolder

* changing Write-Ouput to Write-AzOpsLog

* adding AzOps Log

* Move pipeline

* Reset AzOps pipeline

* AzOps pipeline

[skip ci]

* Merged PR 18: Support for SCMPlatform

Prepares the ground for working with ADO

Related work items: #85

* Merged PR 19: AzOps-ContainerBuildAndPush

Related work items: #86

* Use ADO APIs to raise PRs/comments/labels

* remove unused var

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Devug azure creds

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Remove debugging

* debugthisshiz

* Update triggers

* debug git

* is git installed?

* moar

* Remove debugging

* Add query params for get PR

* Add verbose output

* Add token output

* Change git merge to git reset

* Add force push

* Move token output outside if block

* Attempt response.count for REST response

* Add active check for PR query

* removing stong type from save-azopsmg (#13)

* Update container tag

* Moar variables

* Create ado specific comment

* Add replaceme tags

Co-authored-by: Matt White <mawhi@microsoft.com>
Co-authored-by: Matt White <Matthew.White@microsoft.com>
Co-authored-by: Lyon J Till <158992+ljtill@users.noreply.github.com>
Co-authored-by: Kevin Rowlandson <kevin.rowlandson@monoconsultancy.com>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>

* title & & body for ADO PR

* Remove INPUT prefix from SCMPLATFORM variable name

* Use  $(Build.SourceBranchName) for docker tag

* Updated AzOpsDockerBuild.yml

* Fix env var name

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Update AzOpsDockerBuild.yml for Azure Pipelines

* Add replaceme tags

* Correct GH references

* Remove as this is now included upstream

* Remove explicit -Verbose

* Add Out-Nulls to REST requests

* Remove null redirects

Co-authored-by: Matt White <Matthew.White@microsoft.com>
Co-authored-by: Matt White <mawhi@microsoft.com>
Co-authored-by: Lyon J Till <158992+ljtill@users.noreply.github.com>
Co-authored-by: Kevin Rowlandson <kevin.rowlandson@monoconsultancy.com>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>

* Update public/

* Update guidance/

* Update guidance/

* Move providerfeatures.json & resourceproviders.json

* Update Dockerfile

* Update public/

* Add Azure DevOps support

* Fix export raw templates env var

* Fix auxiliary path

* Update comment formatting

* Add branch name parsing

* Add azure devops global vars

* Add azure devops support

* Update entrypoint.ps1

* Update Invoke-AzOpsGitPull.ps1

* Remove blank space

* Fix parameter name

* Update default scm logic

* Set default scm platform

* Add pull request wait

* Update Invoke-AzOpsGitPush.ps1

* Update Invoke-AzOpsGitPush.ps1

* Update Invoke-AzOpsGitPush.ps1

* Workflow test

* Revert workflow test

* Update push / pull workflow

* Update git push workflow

* Update push workflow

* Workflow test

* Add skip logic

* Fix status variable

* Revert test workflow

Co-authored-by: Matt White <matt.white@microsoft.com>
Co-authored-by: Matt White <Matthew.White@microsoft.com>
Co-authored-by: Matt White <mawhi@microsoft.com>
Co-authored-by: Kevin Rowlandson <kevin.rowlandson@monoconsultancy.com>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>
@ljtill ljtill removed the enhancement New feature or request label Apr 9, 2021
@jasonbrisbin jasonbrisbin mentioned this issue Nov 22, 2021
Merged
6 tasks
daltondhcp added a commit that referenced this issue Feb 17, 2023
@daltondhcp @Jefajers
Subperf staging (#2) (#748)
72f0d5a 
* BaseUpdate

---------

Co-authored-by: Jesper Fajers <jesper@fajers.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Discovery enhancements
3 participants
@ljtill @uday31in @daltondhcp